Refactor security provider instantiation #4605
Conversation
Signed-off-by: Terry Quigley <[email protected]>
terryquigleysas
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4605 +/- ##
==========================================
+ Coverage 65.28% 65.29% +0.01%
==========================================
Files 317 317
Lines 22277 22285 +8
Branches 3582 3582
==========================================
+ Hits 14544 14552 +8
Misses 5941 5941
Partials 1792 1792
|
|
@cwperks This is the latest proposed change for the provider issue. Thanks for your comments so far on the other tickets. |
|
Thanks all for the comments and approvals. Is there anything else you need from me for it to be merged? |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4605-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d97cca822c40c983d560e606577af4019827b9a5
# Push it to GitHub
git push --set-upstream origin backport/backport-4605-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
|
Hi, @terryquigleysas, could you please make a backport manually? |
|
@willyborankin I am out of the office for a few weeks starting today. This will be picked up by @dancristiancecoi |
Signed-off-by: Terry Quigley <[email protected]> (cherry picked from commit d97cca8)
|
@willyborankin created the backport: #4611 |
Description
Category (Refactoring)
Refactor call to add the BouncyCastleProvider in OpenSearchSecurityPlugin.java and any associated code.
Helps towards potential support of FIPS-compatible Bouncy Castle provider. This class does not exist in other providers.
Backwards compatible.
Issues Resolved
Resolves #4583
Derived from and replaces #4588 - please refer to it for additional context
Testing
Bulk Integration Test Github action
Run latest 3.x Core and OpenSearch Security plugin. Smoke tests (Indexing, searching, user creation, role creation, security admin script calls) run against both:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.